Messages in this thread | | | From | Chris Ball <> | Subject | Re: [PATCH v2] mmc:sdhci-pci: Add Support of O2Mirco/BayHubTech SD Host | Date | Sun, 27 Oct 2013 13:02:53 +0000 |
| |
Hi Peter,
On Wed, Oct 23 2013, Peter Guo wrote: > Do you have any comments on this patch?
It would be nice if there were fewer magic constants in the patch, and adding another 200 lines to sdhci-pci seems to suggest that it might be time to split it out into sdhci-pci-o2micro.c.
Thanks,
- Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/>
| |