Messages in this thread | | | Date | Sun, 27 Oct 2013 05:23:48 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCHv2 1/3] Input: twl4030-keypad - add device tree support |
| |
* Pavel Machek <pavel@ucw.cz> [131027 04:48]: > > > > > +#if IS_ENABLED(CONFIG_OF) > > > I'm probably missing something here, but why not #ifdef CONFIG_OF? > > > > I have been told for other drivers, that IS_ENABLED() is > > the prefered way to check for configuration these days. > > CONFIG_OF can not be module, using IS_ENABLED() on it is just wrong.
Good point. Looks like there's IS_BUILTIN that's for boolean options.
Regards,
Tony
| |