Messages in this thread | | | Date | Mon, 28 Oct 2013 10:37:35 +0800 | From | Wei Yang <> | Subject | Re: [PATCH 2/3] percpu: merge two loops when setting up group info |
| |
On Sun, Oct 27, 2013 at 08:35:42AM -0400, Tejun Heo wrote: >On Mon, Oct 21, 2013 at 04:58:12PM +0800, Wei Yang wrote: >> There are two loops setting up the group info of pcpu_alloc_info. They share >> the same logic, so merge them could be time efficient when there are many >> groups. >> >> This patch merge these two loops into one. > >It *looks* correct to me but I'd rather not change this unless you can >show me this actually matters, which I find extremely doubtful given >nr_groups would be in the order of few thousands even on an extremely >large machine.
Tejun, thanks for your review and comments.
I agree with you that the nr_groups won't be very large, which means it will not bring many benefits.
This is just a small code refine. If you don't like it, just drop it :-)
> >Thanks. > >-- >tejun
-- Richard Yang Help you, Help me
| |