Messages in this thread | | | Date | Sat, 26 Oct 2013 22:02:37 +0200 | From | Krzysztof Mazur <> | Subject | Re: [PATCH] atmusb: Fix dynamic_debug macros |
| |
On Sat, Oct 26, 2013 at 12:28:56PM -0700, Joe Perches wrote: > On Sat, 2013-10-26 at 11:55 -0700, Joe Perches wrote: > > Fix use of atm_dbg to all normal pr_debug not dynamic_pr_debug > > because dynamic_pr_debug may not be compiled in at all. > > Greg, please don't apply this one. > I'll resubmit one that actually works. > > (the arg...) should be ... > > > +#define atm_dbg(instance, format, arg...) \ > ^ oops. > > > +#define atm_rldbg(instance, format, arg...) \ > > + pr_debug_ratelimited("ATM dev %d: " format, \ > > + (instance)->atm_dev->number, ##__VA_ARGS__) > > here too. >
Yeah, I initially fixed that with changing "##__VAR_ARGS" to "## arg", but without with "arg..." -> "..." it also compiles and runs correctly.
I tested that only in my configuration - without DEBUG and DYNAMIC_DEBUG - and compile tested that it with DYNAMIC_DEBUG. If you like you can add:
Tested-by: Krzysztof Mazur <krzysiek@podlesie.net>
BTW: the driver is named usbatm, not atmusb.
Thanks, Krzysiek
| |