lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] iio:light:tsl2563: Add DT support
    Hi Grant,

    On Fri, Oct 25, 2013 at 08:10:28PM +0100, Grant Likely wrote:
    > > + - cover-comp-gain : integer used as multiplier for gain
    > > + compensation (default = 1)
    >
    > Should be taos,cover-comp-gain

    Has been updated to "amstaos,cover-comp-gain" in the latest
    patches, see https://lkml.org/lkml/2013/10/25/59

    > Otherwise looks fine to me.

    Is this an acked-by?

    > > + else if (np)
    > > + of_property_read_u32_index(np, "cover-comp-gain", 0,
    > > + &chip->cover_comp_gain);
    >
    > of_property_read_u32() should be sufficient. You don't need the _index
    > variant.

    ah, I missed the function when skipping over linux/of.h.
    I will sent another update.

    -- Sebastian
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-10-26 01:41    [W:7.334 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site