lkml.org 
[lkml]   [2013]   [Oct]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] iio:light:tsl2563: Add DT support
    Date
    On Wed, 23 Oct 2013 23:51:03 +0200, Sebastian Reichel <sre@debian.org> wrote:
    > Add Device Tree support for the TSL2563 driver
    > and document the binding.
    >
    > Signed-off-by: Sebastian Reichel <sre@debian.org>
    > ---
    > .../devicetree/bindings/iio/light/tsl2563.txt | 19 +++++++++++++++++++
    > drivers/iio/light/tsl2563.c | 4 ++++
    > 2 files changed, 23 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/iio/light/tsl2563.txt
    >
    > diff --git a/Documentation/devicetree/bindings/iio/light/tsl2563.txt b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
    > new file mode 100644
    > index 0000000..b52cf4b
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/iio/light/tsl2563.txt
    > @@ -0,0 +1,19 @@
    > +* TAOS TSL2563 ambient light sensor
    > +
    > +Required properties:
    > +
    > + - compatible : should be "taos,tsl2563"
    > + - reg : the I2C address of the sensor
    > +
    > +Optional properties:
    > +
    > + - cover-comp-gain : integer used as multiplier for gain
    > + compensation (default = 1)

    Should be taos,cover-comp-gain

    Otherwise looks fine to me.

    > +
    > +Example:
    > +
    > +tsl2563@29 {
    > + compatible = "taos,tsl2563";
    > + reg = <0x29>;
    > + cover-comp-gain = <16>;
    > +};
    > diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c
    > index ebb962c..bd30b1d 100644
    > --- a/drivers/iio/light/tsl2563.c
    > +++ b/drivers/iio/light/tsl2563.c
    > @@ -699,6 +699,7 @@ static int tsl2563_probe(struct i2c_client *client,
    > struct iio_dev *indio_dev;
    > struct tsl2563_chip *chip;
    > struct tsl2563_platform_data *pdata = client->dev.platform_data;
    > + struct device_node *np = client->dev.of_node;
    > int err = 0;
    > u8 id = 0;
    >
    > @@ -735,6 +736,9 @@ static int tsl2563_probe(struct i2c_client *client,
    >
    > if (pdata)
    > chip->cover_comp_gain = pdata->cover_comp_gain;
    > + else if (np)
    > + of_property_read_u32_index(np, "cover-comp-gain", 0,
    > + &chip->cover_comp_gain);

    of_property_read_u32() should be sufficient. You don't need the _index
    variant.

    > else
    > chip->cover_comp_gain = 1;
    >
    > --
    > 1.8.4.rc3
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/



    \
     
     \ /
      Last update: 2013-10-26 01:41    [W:3.746 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site