Messages in this thread | | | Date | Fri, 25 Oct 2013 11:44:35 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 01/11] Export __smp_call_function_single() |
| |
On Fri, Oct 25 2013, Ingo Molnar wrote: > > * Jens Axboe <axboe@kernel.dk> wrote: > > > The blk-mq core and the blk-mq null driver uses it. > > > > Cc: Ingo Molnar <mingo@kernel.org> > > Signed-off-by: Jens Axboe <axboe@kernel.dk> > > --- > > kernel/smp.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/kernel/smp.c b/kernel/smp.c > > index 0564571..9de461e 100644 > > --- a/kernel/smp.c > > +++ b/kernel/smp.c > > @@ -340,6 +340,7 @@ void __smp_call_function_single(int cpu, struct call_single_data *csd, > > } > > put_cpu(); > > } > > +EXPORT_SYMBOL(__smp_call_function_single); > > I agree with exporting it to in-kernel users, but I'd prefer a _GPL > export for newly exported symbols that are for in-kernel use.
Agree, it should be _GPL. I will update the patch. Can I add your acked-by?
-- Jens Axboe
| |