lkml.org 
[lkml]   [2013]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: Large pastes into readline enabled programs causes breakage from v2.6.31 onwards
    Date
    On Tuesday 03 of September 2013, Arkadiusz Miskiewicz wrote:
    > On Sunday 18 of August 2013, Margarita Manterola wrote:
    > > Hi,
    > >
    > > On Sat, Aug 17, 2013 at 5:28 PM, Pavel Machek <pavel@ucw.cz> wrote:
    > > >> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
    > > >> index 4bf0fc0..2ba7f4e 100644
    > > >> --- a/drivers/tty/n_tty.c
    > > >> +++ b/drivers/tty/n_tty.c
    > > >> @@ -149,7 +149,8 @@ static int set_room(struct tty_struct *tty)
    > > >>
    > > >> * characters will be beeped.
    > > >> */
    > > >>
    > > >> if (left <= 0)
    > > >>
    > > >> - left = ldata->icanon && !ldata->canon_data;
    > > >> + if (waitqueue_active(&tty->read_wait))
    > > >> + left = ldata->icanon && !ldata->canon_data;
    > > >>
    > > >> old_left = tty->receive_room;
    > > >> tty->receive_room = left;
    > > >
    > > > Was this applied? You may want to cc rjw... it is a regression, it is
    > > > not pretty, and it is something I blieve I hit but thought it was some
    > > > kind of "X weirdness".
    > >
    > > There were no replies to the previous mail asking for comments, and as
    > > far as I can see this has not been applied. I don't know who rjw is,
    > > could you be a bit more explicit, please?
    >

    Hi

    Was just going over bug-readline and lkml archives and found no continuation
    of this.

    There was a patch proposed but didn't get applied.
    https://lkml.org/lkml/2013/8/17/31
    Maybe it only needs proper patch submission?

    Looking from bug-readline archives debugging it took huge amount of work and
    would be sad that all that ended up being wasted.

    Whole thread if someone lost it https://lkml.org/lkml/2013/7/25/205

    --
    Arkadiusz Miśkiewicz, arekm / maven.pl
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-10-24 18:21    [W:3.797 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site