Messages in this thread | | | Subject | Re: [PATCH] skd: Replaced custom debug PRINTKs with pr_debug | From | Joe Perches <> | Date | Thu, 24 Oct 2013 08:09:35 -0700 |
| |
On Thu, 2013-10-24 at 12:53 +0100, Jens Axboe wrote: > On Thu, Oct 24 2013, Ramprasad Chinthekindi wrote: > > Hi Jens, > > > > I'm resending the patch to replace custom debug macros with > > pr_debug(). Kindly please review and apply the patch. Thanking you. > > Thanks, that's a nice improvement. Applied.
Is it really much of an improvement?
It leaves possible different behavior with skdev->dbg_level/skd_dbg_level set without linkage to a few printks now.
It also doesn't make use of dynamic debug's +f/+l capability to and always emits __func__/__LINE__.
| |