lkml.org 
[lkml]   [2013]   [Oct]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regmap: debugfs: Fix a boot time crash with early regmap init
On 10/24/2013 12:18 PM, Mark Brown wrote:
> On Thu, Oct 24, 2013 at 12:07:48PM +0300, Tero Kristo wrote:
>
>> + if (!regmap_debugfs_root) {
>> + struct regmap_debugfs_node *node;
>> + node = kzalloc(sizeof(*node), GFP_KERNEL);
>> + if (!node)
>> + return;
>> + node->map = map;
>> + node->name = name;
>> + list_add(&node->link, &regmap_debugfs_early);
>> + return;
>> + }
>> +
>
> init is somewhat parallel so I'd be happier if we locked the list to
> make sure that we don't corrupt the list.

Ok, I added a mutex for protection (later registration might take some
time so didn't want to use spinlock.)

> We also need something to handle removal of items from the list if the
> regmap is destroyed prior to the initcall running (for example in error
> handling cases), otherwise we could end up creating debugfs files
> pointing at devices that no longer exist.

Added cleanup for the list in the regmap_debugfs_exit() call. Sending v2
shortly.

-Tero


\
 
 \ /
  Last update: 2013-10-24 14:21    [W:0.692 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site