lkml.org 
[lkml]   [2013]   [Oct]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Generic WorkQueue Engine (GenWQE) device driver
On Wed, Oct 23, 2013 at 05:06:41PM +0200, Michal Marek wrote:
> On 23.10.2013 16:14, Frank Haverkamp wrote:
> > of course you are right. Let me try again.
> >
> > I hope this looks better now:
> > + dev_info(&pci_dev->dev, "GenWQE driver version: %s %s%u\n",
> > + DRV_VERS_STRING, GENWQE_DEVNAME, cd->card_idx);
> > ...

Also, _no_ driver should ever be doing this type of "hey, look at me,
I'm now loaded!" type syslog spam anymore. It's pointless, and should
be abolished where ever possible. That's one reason we have moved to
the driver init type functions that make this impossible to do, and if
possible, I recommend doing that here as well.

thanks,

greg k-h


\
 
 \ /
  Last update: 2013-10-23 17:41    [W:0.047 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site