Messages in this thread | | | Date | Wed, 23 Oct 2013 19:31:04 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] kernel: context_tracking: use extern function instead of static inline function for user_enter/exit() |
| |
On 10/23/2013 07:15 PM, Steven Rostedt wrote: > On Wed, 2013-10-23 at 19:01 +0800, Chen Gang wrote: > >>> void arch_user_enter(void) >>> { >>> user_enter(); >>> } >>> >> >> OK, thanks. That sounds reasonable to me. I will send related patch to >> arm guys. :-) > > If you do so, don't call it "arch_user_enter()", maybe call it > "asm_user_enter()", as "arch_*" is something used to be called by the > generic code. My mistake in using that as an example. >
Oh, yes, what you said is an example, I need reference it, but should not depend on it.
Hmm... for me "asm_user_enter" seems still a little 'generic' (e.g. "asm-generic", "arch/*/include/asm/"), maybe just use common extern functions' name is enough (e.g. "wrap_user_enter").
But all together, I feel your original fix patch is well enough to me, it seems don't need additional trying. :-)
> -- Steve > > > >
Thanks. -- Chen Gang
| |