| From | Adrian Hunter <> | Subject | [PATCH V2 13/14] perf tools: Do not accept parse_tag_value() overflow | Date | Tue, 22 Oct 2013 10:34:17 +0300 |
| |
parse_tag_value() accepts an "unsigned long" and multiplies it according to a tag character. Do not accept the value if the multiplication overflows.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- tools/perf/util/util.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index c25e57b..28a0a89 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -386,6 +386,8 @@ unsigned long parse_tag_value(const char *str, struct parse_tag *tags) if (s != endptr) break; + if (value > ULONG_MAX / i->mult) + break; value *= i->mult; return value; } -- 1.7.11.7
|