Messages in this thread | | | Date | Wed, 2 Oct 2013 11:42:20 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf tool: simplify a git command in PERF-VERSION-GEN |
| |
* Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> Replace a complex git log invocation with a simpler git rev-parse > invocation. > > Cc: Ingo Molnar <mingo@kernel.org> > Cc: Namhyung Kim <namhyung@gmail.com> > Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> > --- > tools/perf/util/PERF-VERSION-GEN | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/PERF-VERSION-GEN b/tools/perf/util/PERF-VERSION-GEN > index 15a77b7..b23d11b 100755 > --- a/tools/perf/util/PERF-VERSION-GEN > +++ b/tools/perf/util/PERF-VERSION-GEN > @@ -18,7 +18,7 @@ TAG= > if test -d ../../.git -o -f ../../.git > then > TAG=$(git describe --abbrev=0 --match "v[0-9].[0-9]*" 2>/dev/null ) > - CID=$(git log -1 --abbrev=4 --pretty=format:"%h" 2>/dev/null) && CID="-g$CID" > + CID=$(git rev-parse --short HEAD 2>/dev/null) && CID="-g$CID"
This shaves 4 milliseconds off the build time as well.
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
| |