Messages in this thread | | | Date | Wed, 2 Oct 2013 12:11:37 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] perf auto-dep: Speed up feature tests by building them in parallel |
| |
* Jiri Olsa <jolsa@redhat.com> wrote:
> > @@ -388,7 +410,7 @@ else > > has_cplus_demangle := $(call try-cc,$(SOURCE_CPLUS_DEMANGLE),$(FLAGS_CPLUS_DEMANGLE),demangle) > > ifeq ($(has_cplus_demangle),y) > > EXTLIBS += -liberty > > - CFLAGS += -DHAVE_CPLUS_DEMANGLE > > + CFLAGS += -DHAVE_CPLUS_DEMANGLE_SUPPORT > > else > > msg := $(warning No bfd.h/libbfd found, install binutils-dev[el]/zlib-static to gain symbol demangling) > > CFLAGS += -DNO_DEMANGLE > > @@ -400,30 +422,29 @@ else > > endif > > Why not add tests for > has_bfd_iberty/has_bfd_iberty_z/has_cplus_demangle?
Yeah, did not get to that stage yet: I only converted the feature tests that trigger on my system (which is about 80% of them). Will complete the transition.
> We could remove the config/feature-tests.mak completely and other > cleanup like remove try-cc.
Yeah - that will be a nice simplification!
Thanks,
Ingo
| |