Messages in this thread | | | Date | Fri, 18 Oct 2013 20:51:53 -0400 | Subject | Re: [PATCH] time: Fix signedness bug in sysfs_get_uname() and its callers | From | Patrick Palka <> |
| |
On Fri, Oct 18, 2013 at 8:16 PM, John Stultz <john.stultz@linaro.org> wrote: > On 10/11/2013 10:11 AM, Patrick Palka wrote: >> sysfs_get_uname() is erroneously declared as returning size_t even >> though it may return a negative value, specifically -EINVAL. Its >> callers then check whether its return value is less than zero and indeed >> that is never the case for size_t. >> >> This patch changes sysfs_get_uname() to return ssize_t and makes sure >> its callers use ssize_t accordingly. > > So a similar fix has already been queued in tip/timers/core, but this > seems more complete, so I've resolved the collisions with the earlier > fix and queued it for 3.13. > > Would you please take a look at the resulting commit and double check I > didn't flub the conflict resolution? > > https://git.linaro.org/gitweb?p=people/jstultz/linux.git;a=commitdiff;h=891292a767c2453af0e5be9465e95b06b4b29ebe;hp=b7bc50e45111e59419474154736f419a555158d9
Looks good.
| |