lkml.org 
[lkml]   [2013]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tracing: creates 'tracing_is_disabled()'
On Fri, 18 Oct 2013 17:59:41 -0300
"Geyslan G. Bem" <geyslan@gmail.com> wrote:

> This patch creates the function 'tracing_is_disabled ", which
> can be used outside trace.c.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> kernel/trace/trace.c | 5 +++++
> kernel/trace/trace.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 7974ba2..a120a73 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2964,6 +2964,11 @@ int tracing_open_generic(struct inode *inode, struct file *filp)
> return 0;
> }
>
> +inline bool tracing_is_disabled(void)

Nuke the "inline". Gcc and other compilers are smart enough to know to
inline it on a -O2, that we don't need it. Especially, when it's used
in another file.

-- Steve

> +{
> + return (tracing_disabled) ? true: false;
> +}
> +
> /*
> * Open and update trace_array ref count.
> * Must have the current trace_array passed to it.
> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h


\
 
 \ /
  Last update: 2013-10-19 02:21    [W:0.065 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site