Messages in this thread | | | From | Ramkumar Ramachandra <> | Date | Thu, 17 Oct 2013 11:54:04 +0530 | Subject | Re: [PATCH] virtio tools: use ansi versions of asm and volatile |
| |
Rusty Russell wrote: > Ramkumar Ramachandra <artagnon@gmail.com> writes: >> asm and volatile are provided for backward compatibility; use the ansi >> versions __asm__ and __volatile__. > > Really? I don't see that in the gcc documentation. In fact, I didn't > know __volatile__ at all:
Try compiling the program with `gcc -ansi`, and you'll see that "asm" and "volatile" are undeclared. The motivation for my patch comes from barrier() being declared differently in compiler-gcc.h.
However, the tree is polluted with the non-ansi versions anyway; compilers will continue to support them for decades. So, I'd request you to drop the patch.
Thanks.
| |