Messages in this thread | | | Date | Sun, 13 Oct 2013 20:46:52 +0900 | From | Shinya Kuribayashi <> | Subject | Re: [PATCH 2/2] i2c designware add support of I2C standard mode |
| |
On 10/9/13 4:56 PM, Mika Westerberg wrote:> On Tue, Oct 08, 2013 at 05:00:55PM +0200, Romain Baeriswyl wrote: >> Some legacy devices support ony I2C standard mode at 100kHz. >> This patch allows to select the standard mode through the DTS >> with the use of the existing clock-frequency parameter. >> >> When clock-frequency parameter is not set, the fast mode is selected. >> Only when the parameter is set at 100000, the standard mode is selected. >> >> Signed-off-by: Romain Baeriswyl <romainba@abilis.com> >> Reviewed-by: Christian Ruppert <christian.ruppert@abilis.com> > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
I don't have build environment for these patches right now, but both changes 1/2 and 2/2 look good.
It's quite reasonable and makes the code readable to convert {3 => 300} into nsec based one. I should have done so from the beginning, thanks for doing this.
Shinya
| |