Messages in this thread | | | Date | Tue, 1 Oct 2013 18:30:42 +0900 | Subject | Re: [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively | From | Magnus Damm <> |
| |
On Tue, Sep 24, 2013 at 1:12 PM, <takasi-y@ops.dti.ne.jp> wrote: > Make sh clock framework core depend on HAVE_MACH_CLKDEV, and > set it > - y on sh for backward compatibility > - !CONFIG_COMMON_CLK on sh-mobile > This is a preparation for migration to common clock framework > from sh clock framework on sh-mobile. > > Signed-off-by: Takashi Yoshii <takashi.yoshii.zj@renesas.com> > --- > arch/arm/Kconfig | 2 +- > arch/sh/Kconfig | 1 + > drivers/sh/clk/Makefile | 3 +-- > 3 files changed, 3 insertions(+), 3 deletions(-)
Hi Yoshii-san,
Thanks for your patch. I'm sure there is a reason behind this, but I'm trying to understand why you need this modification. It looks to me like you're trying to enable COMMON_CLK on ARCH_SHMOBILE but in my mind it is enough to only enable COMMON_CLK in the case of ARCH_SHMOBILE_MULTI.
During my test using ARCH_SHMOBILE_MULTI on KZM9D I omitted this patch and only used patch 1, 2, 4, 5, and a modified 6 from your series. This worked just fine, but I may be missing something.
Let me know if you really want to keep this patch or not. If it's not needed for MULTIPLATFORM then I suggest that we just drop it.
Cheers,
/ magnus
| |