Messages in this thread | | | Date | Tue, 01 Oct 2013 13:46:49 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 4/7] x86, kaslr: select random base offset |
| |
On 10/01/2013 12:37 PM, Kees Cook wrote: > + > +#include <asm/archrandom.h> > +static inline int rdrand(unsigned long *v) > +{ > + int ok; > + asm volatile("1: " RDRAND_LONG "\n\t" > + "jc 2f\n\t" > + "decl %0\n\t" > + "jnz 1b\n\t" > + "2:" > + : "=r" (ok), "=a" (*v) > + : "0" (RDRAND_RETRY_LOOPS)); > + return ok; > +} > +
This looks just like rdrand_long() in arch/x86/kernel/cpu/rdrand.c and could move into the header file, no?
-hpa
| |