Messages in this thread | | | Date | Wed, 9 Jan 2013 16:20:42 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2] mm: prevent to add a page to swap if may_writepage is unset |
| |
On Wed, 9 Jan 2013 15:21:13 +0900 Minchan Kim <minchan@kernel.org> wrote:
> --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -780,6 +780,8 @@ static unsigned long shrink_page_list(struct list_head *page_list, > if (PageAnon(page) && !PageSwapCache(page)) { > if (!(sc->gfp_mask & __GFP_IO)) > goto keep_locked; > + if (!sc->may_writepage) > + goto keep_locked; > if (!add_to_swap(page)) > goto activate_locked; > may_enter_fs = 1;
We should add a comment here explaining what's going on. But I can't suggest anything which sounds rational because this looks so wrong :(
| |