Messages in this thread | | | Date | Wed, 9 Jan 2013 11:59:11 +0000 | From | Russell King - ARM Linux <> | Subject | Re: [PATCH 2/3] ARM: ux500: Turn on the 'heartbeat' LED trigger |
| |
On Wed, Jan 09, 2013 at 11:56:55AM +0000, Arnd Bergmann wrote: > On Wednesday 09 January 2013, Russell King - ARM Linux wrote: > > > If so, that's wrong, as it covers many more boards than just Snowball > > > and this is only applicable on the Snowball board. So how else can > > > I enable this feature? > > > > And why is it wrong to enable an optional feature in a defconfig which some > > boards using that defconfig may want? > > > > It's less wrong than forcing user selectable options to be mandatorily > > selected. > > Right. The change I suggested fixes the build errors but doesn't actually > make the intended behavior correct. Just using a configuration file is the > right solution here.
Hang on a moment: if the lack of the LEDs support leads to build errors, doesn't that mean there's missing conditional compilation?
| |