lkml.org 
[lkml]   [2013]   [Jan]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] TTY: synclink, small cleanup in dtr_rts()


Am 27.01.2013 22:00, schrieb Joe Perches:
> On Sun, 2013-01-27 at 23:19 +0300, Dan Carpenter wrote:
>> On Sun, Jan 27, 2013 at 12:04:38PM -0800, Joe Perches wrote:
>>> Wouldn't it be clearer still to use | instead of +
>> Yeah. I think it would be, but adding bitflags together instead of
>> doing bitwise ORs is very common as well.
>
> Fortunately, less and less so.
>
> Another option might be to add another #define
> to include/uapi/linux/synclink.h
>
> #define SerialSignal_DTR_RTS (SerialSignal_DTR | SerialSignal_RTS)


Do you really want every possible combination ready as define ?
please stay with: (SerialSignal_DTR | SerialSignal_RTS)
Everyone using serial should know about DTR and RTS

re,
wh


\
 
 \ /
  Last update: 2013-01-28 14:03    [W:0.082 / U:2.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site