Messages in this thread | | | Date | Sun, 27 Jan 2013 02:48:11 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH v2] mm: clean up soft_offline_page() |
| |
On Sat, Jan 26, 2013 at 12:02:11AM -0500, Naoya Horiguchi wrote: > Currently soft_offline_page() is hard to maintain because it has many > return points and goto statements. All of this mess come from get_any_page(). > This function should only get page refcount as the name implies, but it does > some page isolating actions like SetPageHWPoison() and dequeuing hugepage. > This patch corrects it and introduces some internal subroutines to make > soft offlining code more readable and maintainable. > > ChangeLog v2: > - receive returned value from __soft_offline_page and soft_offline_huge_page > - place __soft_offline_page after soft_offline_page to reduce the diff > - rebased onto mmotm-2013-01-23-17-04 > - add comment on double checks of PageHWpoison
Ok for me if it passes mce-test
Reviewed-by: Andi Kleen <andi@firstfloor.org>
-Andi
| |