lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCHv2 1/9] staging: zsmalloc: add gfp flags to zs_create_pool
    From
    Hi Seth, frontswap guys

    On Tue, Jan 8, 2013 at 5:24 AM, Seth Jennings
    <sjenning@linux.vnet.ibm.com> wrote:
    > zs_create_pool() currently takes a gfp flags argument
    > that is used when growing the memory pool. However
    > it is not used in allocating the metadata for the pool
    > itself. That is currently hardcoded to GFP_KERNEL.
    >
    > zswap calls zs_create_pool() at swapon time which is done
    > in atomic context, resulting in a "might sleep" warning.

    I didn't review this all series, really sorry but totday I saw Nitin
    added Acked-by so I'm afraid Greg might get it under my radar. I'm not
    strong against but I would like know why we should call frontswap_init
    under swap_lock? Is there special reason?

    Thanks.
    --
    Kind regards,
    Minchan Kim


    \
     
     \ /
      Last update: 2013-01-25 03:21    [W:2.217 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site