lkml.org 
[lkml]   [2013]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 65/76] ARC: UAPI Disintegrate arch/arc/include/asm
Hi Vineet,

On 24/01/13 05:46, Vineet Gupta wrote:
> On Wednesday 23 January 2013 06:20 PM, David Howells wrote:
>> Vineet Gupta <Vineet.Gupta1@synopsys.com> wrote:
>>
>>> I generated this patch using the scripts you provided. If these look OK to
>>> you, can you please ACK.
>>
>> You need to take a look at uapi/asm/setup.h. It's created as an empty file -
>> which will get discarded by patch. Do you actually need a UAPI instance of
>> that?
>>
>> David
>>
>
> Given that setup.h is exported by include/uapi/asm-generic/Kbuild.asm (as part of
> userspace header ABI) there's no way we can avoid it's uapi sibling - even if
> empty. But to workaround patch discarding it, I will add a placeholder comment in
> generated setup.h (just like you did for arch/cris). Would that take care of it ?
>
> BTW looking at metag port, it seems that <asm/setup.h> does #include
> <uapi/asm/setup.h>, but latter doesn't exist in the repository - is it generated
> for you James or is this same issue which David elucidated to above ?

We have generic-y += setup.h in arch/metag/include/uapi/asm/Kbuild for this

Cheers
James



\
 
 \ /
  Last update: 2013-01-24 11:42    [W:1.609 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site