Messages in this thread | | | Date | Wed, 23 Jan 2013 14:08:28 +0100 | Subject | Re: [ANNOUNCE] 3.8-rc4-nohz3 | From | Sedat Dilek <> |
| |
On Wed, Jan 23, 2013 at 1:20 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: > 2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>: >> On Wed, Jan 23, 2013 at 1:11 PM, Frederic Weisbecker <fweisbec@gmail.com> wrote: >>> 2013/1/23 Sedat Dilek <sedat.dilek@gmail.com>: >>>> On Wed, Jan 23, 2013 at 12:19 PM, Sedat Dilek <sedat.dilek@gmail.com> wrote: >>>>> Hi Frederic, >>>>> >>>>> I wanted to 3.8-rc4-nohz3 [1] here on my Ubuntu/precise AMD64 system. >>>>> >>>>> Unfortunately, the build breaks like this: >>>>> >>>>> ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined! >>>>> ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined! >>>>> >>>> >>>> Looks like you tested with CONFIG_KVM=y (as module fails!). >>> >>> Yep. looks like I forgot some EXPORT_SYMBOL(). >>> >> >> Hmmm, that was my first thought, too, but about... >> >> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >> index c243b81..fff0932 100644 >> --- a/arch/x86/kvm/x86.c >> +++ b/arch/x86/kvm/x86.c >> @@ -5713,7 +5713,7 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu) >> if (req_immediate_exit) >> smp_send_reschedule(vcpu->cpu); >> >> - kvm_guest_enter(); >> + guest_enter(); >> >> if (unlikely(vcpu->arch.switch_db_regs)) { >> set_debugreg(0, 7); > > Yeah, guest_enter and guest_exit need an EXPORT_SYMBOL() in > kernel/context_tracking.c such that the module can find these > functions.
My patch did not fix it!
kernel/context_tracking.c:114:EXPORT_SYMBOL_GPL(guest_enter); kernel/context_tracking.c:123:EXPORT_SYMBOL_GPL(guest_exit);
[ build-log ] ERROR: "guest_enter" [arch/x86/kvm/kvm.ko] undefined! ERROR: "guest_exit" [arch/x86/kvm/kvm.ko] undefined! make[3]: *** [__modpost] Error 1
$ egrep 'CONFIG_KVM|CONFIG_CONTEXT_TRACKING' linux/.config CONFIG_CONTEXT_TRACKING=y # CONFIG_CONTEXT_TRACKING_FORCE is not set CONFIG_KVM_GUEST=y CONFIG_KVM_APIC_ARCHITECTURE=y CONFIG_KVM_MMIO=y CONFIG_KVM_ASYNC_PF=y CONFIG_KVM=m CONFIG_KVM_INTEL=m # CONFIG_KVM_AMD is not set # CONFIG_KVM_MMU_AUDIT is not set
- Sedat -
| |