lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] fs/cifs/cifs_dfs_ref.c: fix potential memory leakage
From
merged into cifs-2.6.git

On Tue, Jan 22, 2013 at 7:36 PM, Jeff Layton <jlayton@redhat.com> wrote:
> On Tue, 22 Jan 2013 19:20:58 -0500
> Cong Ding <dinggnu@gmail.com> wrote:
>
>> When it goes to error through line 144, the memory allocated to *devname is
>> not freed, and the caller doesn't free it either in line 250. So we free the
>> memroy of *devname in function cifs_compose_mount_options() when it goes to
>> error.
>>
>> Signed-off-by: Cong Ding <dinggnu@gmail.com>
>> ---
>> fs/cifs/cifs_dfs_ref.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/fs/cifs/cifs_dfs_ref.c b/fs/cifs/cifs_dfs_ref.c
>> index ce5cbd7..210fce2 100644
>> --- a/fs/cifs/cifs_dfs_ref.c
>> +++ b/fs/cifs/cifs_dfs_ref.c
>> @@ -226,6 +226,8 @@ compose_mount_options_out:
>> compose_mount_options_err:
>> kfree(mountdata);
>> mountdata = ERR_PTR(rc);
>> + kfree(*devname);
>> + *devname = NULL;
>> goto compose_mount_options_out;
>> }
>>
>
> Nice catch. Looks correct to me. Should this also go to stable?
>
> Reviewed-by: Jeff Layton <jlayton@redhat.com>



--
Thanks,

Steve


\
 
 \ /
  Last update: 2013-01-23 07:41    [W:0.027 / U:0.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site