lkml.org 
[lkml]   [2013]   [Jan]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v9 07/20] mfd: omap-usb-tll: Check for missing platform data in probe
    Date
    No need to check for missing platform data in runtime_suspend/resume
    as it makes more sense to do it in the probe function.

    Signed-off-by: Roger Quadros <rogerq@ti.com>
    Reviewed-by: Felipe Balbi <balbi@ti.com>
    ---
    drivers/mfd/omap-usb-tll.c | 15 +++++----------
    1 files changed, 5 insertions(+), 10 deletions(-)

    diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
    index af67b96..3dbbfea 100644
    --- a/drivers/mfd/omap-usb-tll.c
    +++ b/drivers/mfd/omap-usb-tll.c
    @@ -225,6 +225,11 @@ static int usbtll_omap_probe(struct platform_device *pdev)
    return -ENOMEM;
    }

    + if (!pdata) {
    + dev_err(dev, "Platform data missing\n");
    + return -ENODEV;
    + }
    +
    spin_lock_init(&tll->lock);

    tll->pdata = pdata;
    @@ -368,11 +373,6 @@ static int usbtll_runtime_resume(struct device *dev)

    dev_dbg(dev, "usbtll_runtime_resume\n");

    - if (!pdata) {
    - dev_dbg(dev, "missing platform_data\n");
    - return -ENODEV;
    - }
    -
    spin_lock_irqsave(&tll->lock, flags);

    for (i = 0; i < tll->nch; i++) {
    @@ -404,11 +404,6 @@ static int usbtll_runtime_suspend(struct device *dev)

    dev_dbg(dev, "usbtll_runtime_suspend\n");

    - if (!pdata) {
    - dev_dbg(dev, "missing platform_data\n");
    - return -ENODEV;
    - }
    -
    spin_lock_irqsave(&tll->lock, flags);

    for (i = 0; i < tll->nch; i++) {
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2013-01-23 12:22    [W:2.251 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site