Messages in this thread | | | Date | Sat, 19 Jan 2013 17:26:36 +0530 | From | Vineet Gupta <> | Subject | Re: [PATCH v2 48/76] ARC: Module support |
| |
On Friday 18 January 2013 08:20 PM, Arnd Bergmann wrote: > On Friday 18 January 2013, Vineet Gupta wrote: > >> +int module_frob_arch_sections(Elf_Ehdr *hdr, Elf_Shdr *sechdrs, >> + char *secstr, struct module *mod) >> +{ >> + return 0; >> +} >> + >> +void module_arch_cleanup(struct module *mod) >> +{ >> +} >> + >> +int module_finalize(const Elf32_Ehdr *hdr, const Elf_Shdr *sechdrs, >> + struct module *mod) >> +{ >> + return 0; >> +} > These three empty functions are already defined __weak in kernel/module.c > so you can simply omit them here. > > Arnd
Actually a subsequent patch to do dwarf unwinding out of modules has valid code in those. But yes I can take them out from this patch and introduce in the the one which really needs it.
Thx, -Vineet
| |