lkml.org 
[lkml]   [2013]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 17/30] fs: use read_iter and write_iter rather than aio_read and aio_write


On 01/18/2013 03:26 PM, Jeff Moyer wrote:
> Dave Kleikamp <dave.kleikamp@oracle.com> writes:
>
>> @@ -1315,10 +1317,10 @@ static ssize_t aio_rw_vect_retry(struct kiocb *iocb)
>>
>> if ((iocb->ki_opcode == IOCB_CMD_PREADV) ||
>> (iocb->ki_opcode == IOCB_CMD_PREAD)) {
>> - rw_op = file->f_op->aio_read;
>> + rw_op = do_aio_read;
>> opcode = IOCB_CMD_PREADV;
>> } else {
>> - rw_op = file->f_op->aio_write;
>> + rw_op = do_aio_read;
>> opcode = IOCB_CMD_PWRITEV;
>> }
>
> That wants to be rw_op = do_aio_write in the else clause. How did you
> test this patch set?

Yep, that's certainly a bug. I concentrated on testing on loop mounts,
running some fio and ltp testcases, but I'm at a loss to explain how
things seem to work as well as they do. Let's see how where fixing this
leads.

Thanks!
Shaggy

> Cheers,
> Jeff
>


\
 
 \ /
  Last update: 2013-01-18 23:41    [W:0.862 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site