lkml.org 
[lkml]   [2013]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 084/222] pnpacpi: fix incorrect TEST_ALPHA() test
    Date
    3.5.7.3 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alan Cox <alan@lxorguk.ukuu.org.uk>

    commit cdc87c5a30f407ed1ce43d8a22261116873d5ef1 upstream.

    TEST_ALPHA() is broken and always returns 0.

    [akpm@linux-foundation.org: return false for '@' as well, per Bjorn]
    Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@canonical.com>
    ---
    drivers/pnp/pnpacpi/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pnp/pnpacpi/core.c b/drivers/pnp/pnpacpi/core.c
    index e353788..291906e 100644
    --- a/drivers/pnp/pnpacpi/core.c
    +++ b/drivers/pnp/pnpacpi/core.c
    @@ -58,7 +58,7 @@ static inline int __init is_exclusive_device(struct acpi_device *dev)
    if (!(('0' <= (c) && (c) <= '9') || ('A' <= (c) && (c) <= 'F'))) \
    return 0
    #define TEST_ALPHA(c) \
    - if (!('@' <= (c) || (c) <= 'Z')) \
    + if (!('A' <= (c) && (c) <= 'Z')) \
    return 0
    static int __init ispnpidacpi(const char *id)
    {
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2013-01-16 18:44    [W:9.199 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site