lkml.org 
[lkml]   [2012]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: regulator: fan53555: vsel_max does not match with the max voltage?
> -----Original Message-----
> From: Axel Lin [mailto:axel.lin@gmail.com]
> Sent: 2012年9月10日 11:05
> To: Yunfan Zhang
> Cc: Liam Girdwood; Mark Brown; linux-kernel@vger.kernel.org
> Subject: regulator: fan53555: vsel_max does not match with the max voltage?
>
> Hi Yunfan,
> Just found below issue while reading the code:
>
> For FAN53555_CHIP_ID_04,
> di->vsel_min = 603000;
> di->vsel_max = 1411000;
> di->vsel_step = 12826;
> volt[63] = 1411038
>
> Then volt[63] is greater than the vsel_max now.
> This looks does not make sense.

Axel, Thanks for your findings!
Yes, the volt[63] is GT the vsel_max. Actually vsel_max is not used... The max voltage will be bounded by desc->n_voltages. I will make a patch to remove it to avoid confusing. Thanks a lot!
\
 
 \ /
  Last update: 2012-09-10 06:01    [W:0.280 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site