lkml.org 
[lkml]   [2012]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 70/95] fbcon: fix race condition between console lock and cursor timer (v1.1)
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dave Airlie <airlied@redhat.com>

    commit d8636a2717bb3da2a7ce2154bf08de90bb8c87b0 upstream.

    So we've had a fair few reports of fbcon handover breakage between
    efi/vesafb and i915 surface recently, so I dedicated a couple of
    days to finding the problem.

    Essentially the last thing we saw was the conflicting framebuffer
    message and that was all.

    So after much tracing with direct netconsole writes (printks
    under console_lock not so useful), I think I found the race.

    Thread A (driver load) Thread B (timer thread)
    unbind_con_driver -> |
    bind_con_driver -> |
    vc->vc_sw->con_deinit -> |
    fbcon_deinit -> |
    console_lock() |
    | |
    | fbcon_flashcursor timer fires
    | console_lock() <- blocked for A
    |
    |
    fbcon_del_cursor_timer ->
    del_timer_sync
    (BOOM)

    Of course because all of this is under the console lock,
    we never see anything, also since we also just unbound the active
    console guess what we never see anything.

    Hopefully this fixes the problem for anyone seeing vesafb->kms
    driver handoff.

    v1.1: add comment suggestion from Alan.

    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/video/console/fbcon.c | 9 ++++++++-
    1 file changed, 8 insertions(+), 1 deletion(-)

    diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
    index 2e471c2..88e9204 100644
    --- a/drivers/video/console/fbcon.c
    +++ b/drivers/video/console/fbcon.c
    @@ -372,8 +372,15 @@ static void fb_flashcursor(struct work_struct *work)
    struct vc_data *vc = NULL;
    int c;
    int mode;
    + int ret;
    +
    + /* FIXME: we should sort out the unbind locking instead */
    + /* instead we just fail to flash the cursor if we can't get
    + * the lock instead of blocking fbcon deinit */
    + ret = console_trylock();
    + if (ret == 0)
    + return;

    - console_lock();
    if (ops && ops->currcon != -1)
    vc = vc_cons[ops->currcon].d;




    \
     
     \ /
      Last update: 2012-09-10 02:41    [W:0.027 / U:60.840 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site