lkml.org 
[lkml]   [2012]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 05/12] perf tools: include basename for non-glibc systems
On 9/8/12 3:09 AM, Pekka Enberg wrote:
> It's safe to include <libgen.h> on glibc Linux systems as well, no? So
> there's no need to check for __BIONIC__.

Theoretically, yes. In reality compile fails in multiple places.
basename can modify the string passed to it and several places in perf
are passing a string marked const. Oops. I'll fix those places and
remove the BIONIC conditional for libgen.h

David


\
 
 \ /
  Last update: 2012-09-08 17:21    [W:0.129 / U:9.616 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site