Messages in this thread | | | Date | Sat, 08 Sep 2012 08:33:50 -0600 | From | David Ahern <> | Subject | Re: [PATCH v2 05/12] perf tools: include basename for non-glibc systems |
| |
On 9/8/12 3:09 AM, Pekka Enberg wrote: > It's safe to include <libgen.h> on glibc Linux systems as well, no? So > there's no need to check for __BIONIC__.
Theoretically, yes. In reality compile fails in multiple places. basename can modify the string passed to it and several places in perf are passing a string marked const. Oops. I'll fix those places and remove the BIONIC conditional for libgen.h
David
| |