lkml.org 
[lkml]   [2012]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH mmotm] slub: zero page to fix boot crashes
Latest mmotm rarely boots if SLUB is enabled: earlyprintk=vga shows
it crashing with various backtraces. The memset has now been removed
from kmem_cache_open(), so kmem_cache_init() needs to zero its page.
This gets SLUB booting reliably again.

Signed-off-by: Hugh Dickins <hughd@google.com>
---

mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm/mm/slub.c 2012-09-07 12:39:38.136019730 -0700
+++ fixed/mm/slub.c 2012-09-08 19:37:38.608993123 -0700
@@ -3712,7 +3712,7 @@ void __init kmem_cache_init(void)
/* Allocate two kmem_caches from the page allocator */
kmalloc_size = ALIGN(kmem_size, cache_line_size());
order = get_order(2 * kmalloc_size);
- kmem_cache = (void *)__get_free_pages(GFP_NOWAIT, order);
+ kmem_cache = (void *)__get_free_pages(GFP_NOWAIT | __GFP_ZERO, order);

/*
* Must first have the slab cache available for the allocations of the

\
 
 \ /
  Last update: 2012-09-09 06:22    [W:0.027 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site