lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver
On Wed, Sep 05, 2012 at 05:06:04PM +0530, Sourav Poddar wrote:

> +static struct regmap_config smsc_regmap_config = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = SMSC_MAX_REGISTER - 1;

That max_register setup looks very odd...

> + .cache_type = REGCACHE_COMPRESSED,
> +};

Are you sure the compressed type is sensible? It would normally only
make sense with a large number of closely packed registers but this
device has 8 bit register values.

> +#ifdef CONFIG_OF
> + of_property_read_u32(node, "clock", &smsc->clk);
> +#endif

> + ret = regmap_write(smsc->regmap, SMSC_CLK_CTRL, smsc->clk);
> + if (ret)
> + goto err;

What happens on non-DT systems?

> +static int smsc_i2c_remove(struct i2c_client *i2c)
> +{
> + return 0;
> +}

Remove empty functions, though it's rather surprising that there's
nothing at all to do here.. Normally an MFD would at least remove its
children.



\
 
 \ /
  Last update: 2012-09-08 05:41    [W:0.139 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site