[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH v2 08/12] perf tools: fix no return in non-void function
    From: Irina Tirdea <>

    thread_func in builtin-sched.c has an internal loop and never returns.
    The only return from this thread are BUG_ON calls in case return values
    are not 0.

    The compiler on Android complains that the function needs to return a
    non-void value. Adding the noreturn function attribute to fix this error.

    Error in Android:
    target C: perf <= builtin-sched.c
    hardware/intel/linu/tools/perf/builtin-sched.c: In function 'thread_func':
    hardware/intel/linux/tools/perf/builtin-sched.c:476: error: no return
    statement in function returning non-void

    Signed-off-by: Irina Tirdea <>
    tools/perf/builtin-sched.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
    index a25a023..1fecc95 100644
    --- a/tools/perf/builtin-sched.c
    +++ b/tools/perf/builtin-sched.c
    @@ -439,7 +439,7 @@ static u64 get_cpu_usage_nsec_self(int fd)
    return runtime;

    -static void *thread_func(void *ctx)
    +static __attribute__ ((noreturn)) void *thread_func(void *ctx)
    struct task_desc *this_task = ctx;
    u64 cpu_usage_0, cpu_usage_1;

     \ /
      Last update: 2012-09-08 03:41    [W:0.023 / U:0.248 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site