lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc_sysfs_show_hctosys 0 if resume failed
On Sat, 25 Aug 2012 21:19:31 -0500
David Fries <david@fries.net> wrote:

> Subject: [PATCH] rtc_sysfs_show_hctosys 0 if resume failed

This doesn't make much sense. Did you mean "rtc_sysfs_show_hctosys():
display 0 if resume failed"?

> The original rtc_sysfs_show_hctosys returnd 1 if this device was the
> CONFIG_RTC_HCTOSYS_DEVICE device, a later patch checked
> rtc_hctosys_ret from boot, this verifies boot do_settimeofday
> succeeded, and sets rtc_hctosys_ret in resume to indicate when
> adjusting the clock from resume fails.
>
> This uses only CONFIG_RTC_HCTOSYS_DEVICE for conditional compilation
> instead of it and CONFIG_RTC_HCTOSYS. rtc_hctosys_ret was moved to
> class.c so rtc_hctosys can be removed with just a Kconfig change if
> boot time setting isn't desired.

And this makes my head spin. What does the patch actually do? I think
it might fix a bug, but it's unclear what that bug is.

Can you please write a better changelog and title and resend?

Sorry.


\
 
 \ /
  Last update: 2012-09-08 02:41    [W:0.046 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site