lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/11] target: go through normal processing for all zero-length commands
    Date
    Yay, all users of transport_kmap_data_sg now check for a zero-length
    request and/or a too-small parameter list length. We can thus go through
    the normal emulation path even for such commands.

    This means that out-of-bounds reads and writes are now reported correctly
    even if they transfer 0 blocks. Other errors are also reported correctly.

    Testcase: sg_raw /dev/sdb 28 00 80 00 00 00 00 00 00 00
    should fail with ILLEGAL REQUEST / LBA OUT OF RANGE sense
    does not fail without the patch
    (still wrong with the patch, but better: the ASC is INVALID FIELD IN CDB)

    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    ---
    drivers/target/target_core_transport.c | 18 ------------------
    1 files changed, 0 insertions(+), 18 deletions(-)

    diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
    index 09d9279..c071d0b 100644
    --- a/drivers/target/target_core_transport.c
    +++ b/drivers/target/target_core_transport.c
    @@ -2295,24 +2295,6 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
    if (ret < 0)
    goto out_fail;
    }
    - /*
    - * If this command doesn't have any payload and we don't have to call
    - * into the fabric for data transfers, go ahead and complete it right
    - * away.
    - */
    - if (!cmd->data_length &&
    - cmd->t_task_cdb[0] != REQUEST_SENSE &&
    - (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
    - cmd->t_task_cdb[0] == REPORT_LUNS) {
    - spin_lock_irq(&cmd->t_state_lock);
    - cmd->t_state = TRANSPORT_COMPLETE;
    - cmd->transport_state |= CMD_T_ACTIVE;
    - spin_unlock_irq(&cmd->t_state_lock);
    -
    - INIT_WORK(&cmd->work, target_complete_ok_work);
    - queue_work(target_completion_wq, &cmd->work);
    - return 0;
    - }

    atomic_inc(&cmd->t_fe_count);

    --
    1.7.1

    \
     
     \ /
      Last update: 2012-09-08 00:41    [W:0.025 / U:0.132 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site