lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 06/11] target: go through normal processing for zero-length REQUEST_SENSE
    From
    Date
    On Fri, 2012-09-07 at 17:30 +0200, Paolo Bonzini wrote:
    > Now that spc_emulate_request_sense has been taught to process zero-length
    > REQUEST SENSE correctly, drop the special handling of unit attention
    > conditions from transport_generic_new_cmd. However, for now REQUEST SENSE
    > will be the only command that goes through emulation for zero lengths.
    >
    > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    > ---

    and also applied to master for-3.6. Nice work Paolo!

    So given the nature of these changes I'll likely wait end up waiting
    until -rc6 to push these pending for-3.6 bugfixes.

    Roland & hch, please let us know if you have any concerns.

    Thank you!

    --nab

    > drivers/target/target_core_transport.c | 8 +-------
    > 1 files changed, 1 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
    > index 8facb74..09d9279 100644
    > --- a/drivers/target/target_core_transport.c
    > +++ b/drivers/target/target_core_transport.c
    > @@ -2301,6 +2301,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
    > * away.
    > */
    > if (!cmd->data_length &&
    > + cmd->t_task_cdb[0] != REQUEST_SENSE &&
    > (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
    > cmd->t_task_cdb[0] == REPORT_LUNS) {
    > spin_lock_irq(&cmd->t_state_lock);
    > @@ -2308,13 +2309,6 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
    > cmd->transport_state |= CMD_T_ACTIVE;
    > spin_unlock_irq(&cmd->t_state_lock);
    >
    > - if (cmd->t_task_cdb[0] == REQUEST_SENSE) {
    > - u8 ua_asc = 0, ua_ascq = 0;
    > -
    > - core_scsi3_ua_clear_for_request_sense(cmd,
    > - &ua_asc, &ua_ascq);
    > - }
    > -
    > INIT_WORK(&cmd->work, target_complete_ok_work);
    > queue_work(target_completion_wq, &cmd->work);
    > return 0;




    \
     
     \ /
      Last update: 2012-09-07 21:04    [W:0.028 / U:89.548 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site