Messages in this thread | | | Date | Fri, 07 Sep 2012 11:20:19 -0600 | From | David Ahern <> | Subject | Re: [PATCH] perf, ibs: Check syscall attribute flags |
| |
On 9/7/12 11:11 AM, David Ahern wrote: > On 9/7/12 11:07 AM, Robert Richter wrote: >>> Am I reading this right - if exclude_guest is set then perf_ibs_init >>> returns -EINVAL? >> >> Yes, the hardware does not support this. I will look for a solution >> which emulates this is software. > > ugh, that's exactly we need for Intel: if precise is set, exclude_guest > must be set. > > In perf I would like to set exclude_guest if precise is set -- what I > mentioned yesterday for the patch https://lkml.org/lkml/2012/7/20/437. > With my patch -e cycles:p on AMD will then fail EINVAL.
I see now... intel returns ENOTSUP if exclude_guest is not set, amd returns EINVAL if it is set.
For the AMD case the fallback_missing_features code kicks in for perf-top and perf-record; I just need to fix up the pr_debug for that case.
David
| |