lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 09/12] perf diff: Add weighted diff computation way to compare hist entries
    Em Fri, Sep 07, 2012 at 10:33:04PM +0900, Namhyung Kim escreveu:
    > 2012-09-07 (금), 11:28 +0200, Jiri Olsa:
    > > On Fri, Sep 07, 2012 at 02:58:19PM +0900, Namhyung Kim wrote:
    > > > I don't see why this do { } while(0) loop is necessary.
    > > > How about this?
    > > >
    > > > w1 = strtol(opt, &tmp, 10);
    > > > if (*tmp != ',')
    > > > goto error;
    > > >
    > > > opt = tmp + 1;
    > > > w2 = strtol(opt, &tmp, 10);
    > > > if (*tmp != '\0')
    > > > goto error;
    > > >
    > > > if (!w1 || !w2)
    > > > goto error;
    > >
    > > I do this not to use labels & goto ;)
    >
    > But isn't it usual? Do you have a reason not to do it?

    People don't like goto's, but that is overstated, for error handling it
    is perfectly fine :-)

    > I was a bit confused finding which path actually make it a loop... but
    > there's none. :-/

    - Arnaldo
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-09-07 18:41    [W:0.032 / U:30.560 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site