Messages in this thread | | | Date | Fri, 7 Sep 2012 17:50:57 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 5/7] uprobes: Do not (ab)use TIF_SINGLESTEP/user_*_single_step() for single-stepping |
| |
On 09/07, Srikar Dronamraju wrote: > > Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Thanks!
(and thanks, I'll fix the typo in 2/7 you pointed out)
> > void arch_uprobe_enable_step(struct arch_uprobe *auprobe) > > { > > - struct uprobe_task *utask = current->utask; > > - struct arch_uprobe_task *autask = &utask->autask; > > + struct task_struct *task = current; > > Any particular reason to use task instead of current?
No particular reason, and I think in this case asm will be the same.
Please let me know if you prefer to remove this variable, I'll redo this patch.
Oleg.
| |