Messages in this thread | | | Subject | Re: [PATCH 1/3] tools lib traceevent: Get rid of die() from pretty_print() | From | Steven Rostedt <> | Date | Fri, 07 Sep 2012 10:38:04 -0400 |
| |
On Fri, 2012-09-07 at 11:49 +0900, Namhyung Kim wrote: > From: Namhyung Kim <namhyung.kim@lge.com> > > There are three cases that call die() in the pretty_print. > > 1. insufficient number of argument: cannot proceed anymore. > 2. too long format conversion specifier: truncate and proceed. > 3. bad size specifier in format string: skip and proceed. > > For all cases, convert die to do_warning, mark the event as > EVENT_FL_FAILED and print error message at the last. > > Cc: Frederic Weisbecker <fweisbec@gmail.com> > Cc: Steven Rostedt <rostedt@goodmis.org> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Thanks Namyung!
Arnaldo,
Please add my "Acked-by: Steven Rostedt <rostedt@goodmis.org>" to all three of these patches.
-- Steve
| |