lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 15/19] mfd: Don't convert just one IRQ using irqdomain if a range is provided
Date
MFD core code attempts to convert specified hardware (local) IRQ
numbers to virtual-IRQs, which something Linux can understand. This
works great when only one IRQ is specified. However, converting
entire ranges is currently unsupported. If this occurs we issue a
kernel warning to inform the user of this, but we continue to
convert the first specified IRQ anyway and replace the range. This
is not the correct behaviour. This patch ensures that if a range
is specified, it is left untouched.

CC: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/mfd/mfd-core.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index f8b7771..f07cf69 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -126,10 +126,12 @@ static int mfd_add_device(struct device *parent, int id,
} else if (cell->resources[r].flags & IORESOURCE_IRQ) {
if (domain) {
/* Unable to create mappings for IRQ ranges. */
- WARN_ON(cell->resources[r].start !=
- cell->resources[r].end);
- res[r].start = res[r].end = irq_create_mapping(
- domain, cell->resources[r].start);
+ if (!WARN_ON(cell->resources[r].start !=
+ cell->resources[r].end))
+ res[r].start = res[r].end =
+ irq_create_mapping(
+ domain,
+ cell->resources[r].start);
} else {
res[r].start = irq_base +
cell->resources[r].start;
--
1.7.9.5


\
 
 \ /
  Last update: 2012-09-07 14:43    [W:0.495 / U:0.264 seconds]
©2003-2014 Jasper Spaans. Advertise on this site