lkml.org 
[lkml]   [2012]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ix86: improve determination of X86_MINIMUM_CPU_FAMILY
>>> On 07.09.12 at 09:31, Jan Beulich wrote:
>>>> On 07.09.12 at 09:16, "H. Peter Anvin" <hpa@zytor.com> wrote:
> > Erk, this isn't right either. We're not supposed to include
> > CPUID-enumerable features here, so X86_CMOV, X86_CMPXCHG64 and X86_TSC
> > don't belong, and should instead be done via required-features.h.
>
> Ah, so I got misguided by there already being a CPUID-detectable
> feature here (X86_CMPXCHG64). And by the fact that e.g. having
> M686 (or better) selected is then in fact not expected to have a
> relationship to the value chosen here (worth a comment perhaps).
>
> Further, the "6" case is then completely pointless - X86_P6_NOP
> depends on X86_64. And with all features the kernel cares about
> that got added with Pentium and later being CPUID-enumerable,
> the "5" case would then be superfluous too.

Plus perhaps the X86_64 line should then also be changed into
"depends on X86_32", as all cared about features on x86-64 are
CPUID-enumerable.

Jan



\
 
 \ /
  Last update: 2012-09-07 12:02    [W:0.039 / U:2.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site