lkml.org 
[lkml]   [2012]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC,PATCH v2] efi: Add support for a UEFI variable filesystem
Hi Matt,

> I think this is the problematic chunk of code,
>
> static int efivars_unlink(struct inode *dir, struct dentry *dentry)
> {
> struct efivar_entry *var = dentry->d_inode->i_private;
> struct efivars *efivars = var->efivars;
> efi_status_t status;
>
> spin_lock(&efivars->lock);
>
> status = efivars->ops->set_variable(var->var.VariableName,
> &var->var.VendorGuid,
> 0, 0, NULL);
>
> For deleting authenticated variables Attributes, DataSize and Data need
> to be non-zero. I think DataSize == AuthInfo descriptor. Peter?

That's correct, but we can't use unlink to delete a secure variable, we
need to do a write instead, in order to provide the authentication
descriptor.

But yes, we may need to alter the efivars_file_write path so that such a
write actually results in the dentry being removed...

Cheers,


Jeremy




\
 
 \ /
  Last update: 2012-09-06 20:42    [W:0.069 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site