lkml.org 
[lkml]   [2012]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 09/11 V5] workqueue: rebind newly created worker
    From
    On Wed, Sep 5, 2012 at 6:37 PM, Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
    > when the newly created needs to be rebound. exile it!
    > it will rebind itself in worker_thead().
    >
    > It just prepares, this code is useless until
    > "we unbind/rebind without manager_mutex"
    >
    > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
    > ---
    > kernel/workqueue.c | 5 +++++
    > 1 files changed, 5 insertions(+), 0 deletions(-)
    >
    > diff --git a/kernel/workqueue.c b/kernel/workqueue.c
    > index 223d128..819c84e 100644
    > --- a/kernel/workqueue.c
    > +++ b/kernel/workqueue.c
    > @@ -1838,6 +1838,11 @@ static void manager_start_worker(struct worker *worker, struct worker *manager)
    >
    > /* copy the flags. also unbind the worker if the manager is unbound */
    > worker->flags |= manager->flags & WORKER_COPY_FLAGS;
    > +
    > + if (need_to_rebind_worker(worker)) {
    > + /* exile it, and let it rebind itself */
    > + list_del_init(&worker->entry);

    Sorry, we should not add it to idle_list.
    "add and then remove " is wrong here.

    > + }
    > }
    >
    > /**
    > --
    > 1.7.4.4
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/


    \
     
     \ /
      Last update: 2012-09-05 19:02    [W:3.157 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site